Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NAE-2016] Global roles for menu items permissions #276

Merged
merged 3 commits into from
Nov 20, 2024
Merged

[NAE-2016] Global roles for menu items permissions #276

merged 3 commits into from
Nov 20, 2024

Conversation

machacjozef
Copy link
Member

@machacjozef machacjozef commented Nov 18, 2024 •
edited by jira bot
Loading

Description

Implements NAE-2016

Dependencies

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

  • <Name of a test [test file](link to the test file)>

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc.>

Name Tested on
OS macOS Sequoia 15.0
Runtime Java 11.0.25
Dependency Manager Maven 3.9.9
Framework version Spring Boot 2.7.18
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @tuplle @Smotanka
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

@machacjozef
[NAE-2016] Global roles for menu items permissions
f00373e 
- pridanie globalnej roly:
 def allowedRoles = [ "system"    : "GLOBAL_ROLE",
                      "super_admin"    : "GLOBAL_ROLE" ]

- edit preference_item.xml
@machacjozef machacjozef added the improvement A change that improves on an existing feature label Nov 18, 2024
@machacjozef machacjozef self-assigned this Nov 18, 2024
renczesstefan
renczesstefan previously approved these changes Nov 19, 2024
View reviewed changes
@Retoocs Retoocs self-requested a review November 19, 2024 12:11
@machacjozef machacjozef merged commit 0aa9619 into release/6.4.0 Nov 20, 2024
6 checks passed
@machacjozef machacjozef deleted the NAE-2016 branch November 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renczesstefan renczesstefan renczesstefan approved these changes

@tuplle tuplle tuplle approved these changes

@Retoocs Retoocs Retoocs approved these changes

Assignees

@machacjozef machacjozef

Labels
improvement A change that improves on an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@machacjozef @Retoocs @tuplle @renczesstefan